Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stack]: redesign errors - 4 #2363

Closed
wants to merge 12 commits into from
Closed

[stack]: redesign errors - 4 #2363

wants to merge 12 commits into from

Conversation

mehulmathur16
Copy link
Collaborator

No description provided.

@mehulmathur16 mehulmathur16 self-assigned this Jul 6, 2024
@mehulmathur16 mehulmathur16 marked this pull request as draft July 6, 2024 21:52
@codecov Codecov
Copy link

codecov bot commented Jul 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.15385% with 82 lines in your changes missing coverage. Please review.

Project coverage is 85.62%. Comparing base (967f15c) to head (2aaf3e3).

Files Patch % Lines
src/core/error.rs 8.88% 41 Missing ⚠️
tailcall-prettier/src/error.rs 0.00% 11 Missing ⚠️
src/core/grpc/error.rs 44.44% 10 Missing ⚠️
tailcall-tracker/src/error.rs 0.00% 8 Missing ⚠️
src/cli/runtime/mod.rs 0.00% 7 Missing ⚠️
src/cli/generator/generator.rs 33.33% 2 Missing ⚠️
src/core/rest/directive.rs 66.66% 2 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           error-re-design    #2363      +/-   ##
===================================================
- Coverage            85.89%   85.62%   -0.28%     
===================================================
  Files                  242      242              
  Lines                22400    22483      +83     
===================================================
+ Hits                 19241    19251      +10     
- Misses                3159     3232      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehulmathur16 mehulmathur16 marked this pull request as ready for review July 7, 2024 18:31
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jul 12, 2024
@tusharmath tusharmath marked this pull request as draft July 13, 2024 10:37
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jul 13, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jul 18, 2024
@github-actions GitHub Actions
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath Awaiting requested review from tusharmath

Assignees

@mehulmathur16 mehulmathur16

Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mehulmathur16